[Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

Richard W.M. Jones rjones at redhat.com
Fri Feb 28 14:07:00 UTC 2014


On Fri, Feb 28, 2014 at 02:35:56PM +0100, Hilko Bengen wrote:
> +if HAVE_OCAMLOPT
> +OBJECTS = $(deps)
> +else
> +OBJECTS = $(patsubst %.cmx,%.cmo,$(deps))

There's something about automake 1.13 which breaks use of patsubst /
subst (or any GNU make extension used in certain automake variables).

I can't test if it will specifically break this because I don't have
access to any machines that don't have ocamlopt, but it's something to
watch out for.

In any case, I have pushed this since it works fine for me.

Something for the future: It'd be nice to use automake to build
objects.  This is possible if the program contains at least one C
object file.  See:
https://github.com/libguestfs/supermin/blob/master/src/Makefile.am#L96
https://github.com/libguestfs/supermin/blob/master/src/supermin-link.sh.in

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the Libguestfs mailing list