[Libguestfs] RFC: copy-attributes command

[Pino Toscano]

On Friday 10 January 2014 16:55:38 Richard W.M. Jones wrote:
> On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote:
> > +int
> > +copy_xattrs (const char *src, const char *dest)
> > +{
> > +  abort ();
> > +}
> 
> Is this called in the case where someone does
> 
>   copy-attributes foo bar xattributes:true
> 
> on a version of libguestfs with no support for xattrs?  It's probably
> better to silently ignore this case instead of crashing.

This version shouldn't be ever called, since it is called when 
optgroup_linuxxattrs_available returns true, which is not the case in 
the !HAVE_LINUX_XATTRS block (where the abort version of copy_xattrs is 
implemented).

-- 
Pino Toscano