[Libguestfs] [PATCH 4/7] libvirt domain: Allow network drives with no <host> elements.

Richard W.M. Jones rjones at redhat.com
Thu Jan 23 11:50:52 UTC 2014


This is valid for some network drives:

<source protocol='rbd' name='abc-def/ghi-jkl'/>

instead of this:

<source protocol='rbd' name='abc-def/ghi-jkl'>
  <host name='foo' port='1234'/>
</source>

Allow both forms.
---
 src/libvirt-domain.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index ace2e00..af9770f 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -541,8 +541,7 @@ for_each_disk (guestfs_h *g,
         xphost = xmlXPathEvalExpression (BAD_CAST "./source/host",
                                              xpathCtx);
         if (xphost == NULL ||
-            xphost->nodesetval == NULL ||
-            xphost->nodesetval->nodeNr == 0)
+            xphost->nodesetval == NULL)
           continue;
 
         /* This gives us a list of <host> elements, which each have a
-- 
1.8.4.2




More information about the Libguestfs mailing list