[Libguestfs] [PATCH 2/7] lib: Use vk->len for string conversion

Hilko Bengen bengen at hilluzination.de
Mon Jan 13 15:59:23 UTC 2014


* Richard W.M. Jones:

> On Mon, Jan 13, 2014 at 01:17:52PM +0000, Richard W.M. Jones wrote:
>> Is there a reason for this patch?  It seems like just an optimization.
>
> OK, I see that the reason is to avoid calling _hivex_utf8_strlen which
> would fail for the name containing a \0 character.  However I still
> think we need to keep that check.

You're right. I have pulled the check into hivex_value_key().

Cheers,
-Hilko




More information about the Libguestfs mailing list