[Libguestfs] [PATCH] builder: remove unused variables

Pino Toscano ptoscano at redhat.com
Thu Jan 30 16:10:42 UTC 2014


On Thursday 30 January 2014 15:53:10 Richard W.M. Jones wrote:
> On Thu, Jan 30, 2014 at 02:44:13PM +0100, Pino Toscano wrote:
> > Leftovers of the list_entries_short+list_entries_long split done in
> > 91aae893c70b3877b31803800ba77836fd7a45e8.
> 
> I think you have to write the word "commit " before the hash, so that
> various tools like github know it's a commit hash.  (Actually, I've
> always assumed this, but not tested it).

I've seen different degrees in supporting this by different tools, i.e. 
some of them able to link to commits just with the hash, while others 
needing the "commit " prefix.
In any case, adding the prefix to make both happy is straightforward 
enough.

> ACK.

Commit text amended and pushed, thanks.

-- 
Pino Toscano




More information about the Libguestfs mailing list