[Libguestfs] [PATCH] appliance: init: run ldconfig

[Richard W.M. Jones]

On Tue, Jul 15, 2014 at 11:04:37AM +0200, Pino Toscano wrote:
> On Tuesday 15 July 2014 09:50:24 Richard W.M. Jones wrote:
> > On Mon, Jul 14, 2014 at 11:29:52AM +0200, Pino Toscano wrote:
> > > Run ldconfig early in the init script, so libraries outside standard
> > > library paths but with a proper ld.so configuration file pointing at
> > > them can be found.
> > 
> > [...]
> > 
> > Yes, I have hit a problem where ldconfig was needed.
> > 
> > > +# Make sure to find all the libraries, also those in non-standard
> > > place +# but with a proper ld.so configuration pointing at them
> > 
> > > +ldconfig || :
> > You don't need ||: in this script.
> 
> Removed, thanks.
> 
> > How much time does this add to the start of the appliance?  ie.
> > if you run
> > 
> >   time ./run guestfish -a /dev/null run
> > 
> > before and after what is the difference?
> 
> I didn't find any slowdowns since I started using it locally for the 
> last couple of weeks; with the command above I get more or less the same 
> time, i.e. ~2.5s on my machine (I get times between ~2.52 and ~2.57 both 
> before and after).

Should be good then, ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org