[Libguestfs] [PATCH v3 00/10] Add discard support.

[Richard W.M. Jones]

On Wed, Mar 12, 2014 at 05:19:19PM +0100, Pino Toscano wrote:
> On Wednesday 12 March 2014 14:26:07 Richard W.M. Jones wrote:
> > This set of patches:
> > 
> >  - Adds new APIs to support discard in libguestfs.
> > 
> >  - Adds discard support to virt-format.
> > 
> >  - Adds discard support to virt-sysprep.
> > 
> >  - Implements virt-sparsify --in-place.
> > 
> > This is now working, after fixing the rather stupid bug in fstrim.
> > 
> > I've pushed the ones which were ACKed previously + the fstrim fix.
> 
> Sounds good, just a couple of trivial questions/notes:
> 
> - blkdiscard and blkdiscardzeroes look quite similar although one is an
>   operation and the other is a "query", would it be possible to give
>   them clearer names? Or it is better to have them more close to what
>   they actually do?

I'd prefer to keep these names similar to the Linux concepts
(which is how we've done other APIs).

> - is there any way to check at runtime for the availability of those two
>   functions in the kernel/fs, and maybe advertise that as "feature"
>   (guestfs_available, etc)?

Good idea.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v