[Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

Hilko Bengen bengen at hilluzination.de
Sat Mar 22 10:36:33 UTC 2014


* Richard W.M. Jones:

> On Fri, Feb 28, 2014 at 02:35:56PM +0100, Hilko Bengen wrote:
>> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am
>> index 5dd2c9b..708b2e7 100644
>> --- a/ocaml/Makefile.am
>> +++ b/ocaml/Makefile.am
> [...]
>> +# Tell version 3.79 and up of GNU make to not build goals in this
>> +# directory in parallel.
>> +.NOTPARALLEL:
>
> ^ This makes building the OCaml subdirectory very slow (I normally
> build with MAKEFLAGS=-j9).  Was there a reason for adding this?

I think I added this because both the mlguestfs.cma and mlguestfs.cmxa
targets generate libmlguestfs.a:

mlguestfs.cma: libguestfsocaml.a guestfs.cmo
	$(OCAMLMKLIB) -o mlguestfs \
	  $(libguestfsocaml_a_OBJECTS) guestfs.cmo \
	  -L$(top_builddir)/src/.libs -lguestfs

mlguestfs.cmxa: libguestfsocaml.a guestfs.cmx
	$(OCAMLMKLIB) -o mlguestfs \
	  $(libguestfsocaml_a_OBJECTS) guestfs.cmx \
	  -L$(top_builddir)/src/.libs -lguestfs

As far as I know, those are the only targets that shouldn't be run
parallel. 

I think that an extra target (mlguestfs.cmxa: mlguestfs.cma) would make
the .NOTPARALLEL unnecessary.

Cheers,
-Hilko




More information about the Libguestfs mailing list