[Libguestfs] [PATCH 3/9] build: check for libintl, and use it

Richard W.M. Jones rjones at redhat.com
Tue Nov 4 18:17:14 UTC 2014


On Tue, Nov 04, 2014 at 05:20:12PM +0100, Pino Toscano wrote:
> On Tuesday 04 November 2014 16:09:56 Richard W.M. Jones wrote:
> > On Tue, Nov 04, 2014 at 04:35:26PM +0100, Pino Toscano wrote:
> > > Look for libint/gettext and link to it; this properly detects
> > > whether
> > > libint is part of libc.
> > 
> > I'm a little confused by this patch, and also worried that it may be
> > reverting commit 75514ab57a.
> 
> It is basically looking for whatever provides the *gettext and 
> bindtextdomain functions, not caring about embedded libintl copies.  If 
> they are in libc (like implemented in GNU libc), then the LIBINTL & 
> LTLIBINTL variables are empty, otherwise they will contain the library 
> (usually an external libintl.so).
> 
> > Does this require gettextize?
> 
> Definitely not; this commit does not change the way messages are 
> extracted.

OK, ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list