[Libguestfs] [synnefo-devel] Re: [PATCH 1/1] inspect: Fix a bug in the *BSD root detection

[Richard W.M. Jones]

On Fri, Nov 28, 2014 at 06:03:15PM +0200, Nikos Skalkotos wrote:
> LGTM
> 
> Another thing concerning the disklabel partitions is that
> list_filesystems() will print both /dev/sda1 and /dev/sda5 as ufs file
> systems. I don't know if you care to change this. The fact is that both
> are mountable.

While this could confuse some clients, I'm not sure that attempting to
fix it would improve the situation, so I think it's best to leave it.

> P.S. I wish the kernel folks would stop treating the disklabel
> partitions as logical partitions. Logical partitions are sequential,
> there are no gaps in the numbering. On the other hand disklabel may
> have gaps like the MBR partitions. Having defined partitions 'a', 'b'
> and 'c' is completely different than having defined partitions 'a', 'c'
> and 'd'. The kernel in both cases will show /dev/sda5 and /dev/sda6. I
> wonder if they could get convinced to change that...

Agreed on the problem.

Thanks - I will push the modified patch shortly.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW