[Libguestfs] [PATCH] list-applications: Add support for pacman

[Nikos Skalkotos]

OK, I'll try to fix the epoch thing for all three.

Nikos


On 17 November 2014 13:49, Richard W.M. Jones <rjones at redhat.com> wrote:
> On Mon, Nov 17, 2014 at 01:41:28PM +0200, Nikos Skalkotos wrote:
>> OK, I'll make the suggested changes and I'll try to come up with a new
>> patch by tomorrow or the day after tomorrow. I just noticed that a
>> space is missing between STREQ and ( in the key assignment code which
>> violates the project's coding style. I'll fix that too.
>>
>> For a test-case, I can write a make-archlinux-img.sh script and send
>> it in another patch. It's not big deal.
>>
>> Another thing, I left out of the patch the epoch translation. Pacman's
>> version formats looks like this: epoch:version-rel. You have the epoch
>> hard-coded to 0 in list_applications_deb() and
>> list_applications_rpm(),
>
> Hmm, this is a bug ...
>
>> so I did the same but I can implement it for
>> the sake of completeness. Should I be using the
>> guestfs___parse_unsigned_int() function for the string to int
>> conversion?
>
> Yes, or sscanf.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-top is 'top' for virtual machines.  Tiny program with many
> powerful monitoring features, net stats, disk stats, logging, etc.
> http://people.redhat.com/~rjones/virt-top