[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/6] btrfs: add optional parameter `ro' to btrfs_subvolume_snapshot



On Friday 21 November 2014 13:17:56 Hu Tao wrote:
> diff --git a/generator/actions.ml b/generator/actions.ml
> index fe492e6..850e58d 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -10217,7 +10217,7 @@ See C<guestfs_get_e2generation>." };
> 
>    { defaults with
>      name = "btrfs_subvolume_snapshot";
> -    style = RErr, [Pathname "source"; Pathname "dest"], [];
> +    style = RErr, [Pathname "source"; Pathname "dest"], [OBool "ro"];
>      proc_nr = Some 322;
>      optional = Some "btrfs"; camel_name = "BTRFSSubvolumeSnapshot";
>      tests = [
> @@ -10228,7 +10228,7 @@ See C<guestfs_get_e2generation>." };
>           ["btrfs_subvolume_create"; "/test1"];
>           ["btrfs_subvolume_create"; "/test2"];
>           ["btrfs_subvolume_create"; "/dir/test3"];
> -         ["btrfs_subvolume_snapshot"; "/dir/test3"; "/dir/test4"]]), []
> +         ["btrfs_subvolume_snapshot"; "/dir/test3"; "/dir/test5"; "true"]]), [] ];
>      shortdesc = "create a writable btrfs snapshot";
>      longdesc = "\

Ah, forgot to add: can you please document the new "ro" optarg in the
longdesc?

-- 
Pino Toscano


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]