[Libguestfs] [PATCH] builder: pass Sources.source objects directly

Richard W.M. Jones rjones at redhat.com
Fri Oct 31 16:23:12 UTC 2014

On Fri, Oct 31, 2014 at 04:30:17PM +0100, Pino Toscano wrote:
> -let get_index ~prog ~verbose ~downloader ~sigchecker ~proxy source =
> +let get_index ~prog ~verbose ~downloader ~sigchecker { Sources.uri; proxy; } =

I have a feeling that 'proxy;' is a OCaml 4-ism, so it probably
wouldn't work on RHEL 6.  You can use 'proxy = proxy' instead.  Also
the final semicolon is not needed.

> +    fun { Sources.uri; gpgkey } ->

Same sort of thing here.

> +      fun { Sources.uri; gpgkey } ->

And here.

ACK to 2/3 and 3/3, with those changes.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.

More information about the Libguestfs mailing list