[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] rpm: use the rpm library instead of invoking rpm



On Wed, Sep 17, 2014 at 01:58:25PM +0200, Pino Toscano wrote:
> -  Config.rpm <> "no" && Config.rpm2cpio <> "no" &&
> +  Config.rpm <> "no" && Config.rpm2cpio <> "no" && (rpm_is_available ()) &&

Unnecessary parens: function application binds tightest in functional
languages.  There are a couple more of the same thing below.

Seems reasonable after this change, so ACK.

Once you've pushed this I'm going to add this to Rawhide to get
more testing.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]