[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check



On Tue, Sep 23, 2014 at 04:00:44PM +0200, Pino Toscano wrote:
> On Tuesday 23 September 2014 17:20:27 Hu Tao wrote:
> > Signed-off-by: Hu Tao <hutao cn fujitsu com>
> > ---
> >  p2v/gui.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/p2v/gui.c b/p2v/gui.c
> > index a50307d..2df5017 100644
> > --- a/p2v/gui.c
> > +++ b/p2v/gui.c
> > @@ -69,7 +69,7 @@ static GtkWidget *run_dlg,
> >    *cancel_button;
> > 
> >  /* The entry point from the main program.
> > - * Note that gtk_init etc have already been called in main().
> > + * Note that gtk_init etc have already been called in main_().
> >   */
> >  void
> >  gui_application (struct config *config)
> 
> Maybe it would be better to just remove () from the commit; after all, 
> earlier in that comment gtk_init has no () either.

I'm not exactly sure what the problem is (except that syntax-check
should really be ignoring comments), but can we remove the
parentheses?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]