[Libguestfs] [PATCH 1/2] firstboot: Factor out regular expression constant.
Pino Toscano
ptoscano at redhat.com
Mon Apr 27 14:28:52 UTC 2015
On Monday 27 April 2015 15:15:06 Richard W.M. Jones wrote:
> Don't need to evaluate this every time we call the function.
> ---
> customize/firstboot.ml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/customize/firstboot.ml b/customize/firstboot.ml
> index b12d616..c4af7a9 100644
> --- a/customize/firstboot.ml
> +++ b/customize/firstboot.ml
> @@ -27,8 +27,10 @@ open Regedit
> let unix2dos s =
> String.concat "\r\n" (Str.split_delim (Str.regexp_string "\n") s)
>
> -let sanitize_name n =
> - Str.global_replace (Str.regexp "[^A-Za-z0-9_]") "-" n
> +let sanitize_name =
> + let rex = Str.regexp "[^A-Za-z0-9_]" in
> + fun n ->
> + Str.global_replace rex "-" n
>
> (* For Linux guests. *)
> module Linux = struct
LGTM.
--
Pino Toscano
More information about the Libguestfs
mailing list