[Libguestfs] [PATCH] v2v: convert libvirt display listen configuration (RHBZ#1174073)

Pino Toscano ptoscano at redhat.com
Tue Apr 14 09:20:21 UTC 2015


On Tuesday 14 April 2015 10:05:46 Richard W.M. Jones wrote:
> On Tue, Apr 14, 2015 at 10:40:57AM +0200, Pino Toscano wrote:
> >  and s_display_type = Window | VNC | Spice
> > +and display_listen =
> > +  | LNone
> > +  | LAddress of string
> > +  | LNetwork of string
> 
> Can we call this type 's_display_listen' for consistency?

Makes sense, changed.

> I was trying to see if OVF (input) files have some concept of port or
> address, but they don't appear to.
> 
> Anyway, ACK with the above change.

Pushed with the aforementioned change.

Thanks,
-- 
Pino Toscano




More information about the Libguestfs mailing list