[Libguestfs] [PATCH v4] dib: handle unsetting functions in environment

[Pino Toscano]

On Wednesday 12 August 2015 11:14:21 John Eckersberg wrote:
> If a function name, with its trailing parentheses, is in the
> environment , trying to unset it will error out with a message of "not
> a valid identifier".  Handle this as a special case, and unset it with
> the -f option which can handle the parentheses in the supplied
> identifier.
> ---
>  dib/dib.ml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dib/dib.ml b/dib/dib.ml
> index d730527..16149ae 100644
> --- a/dib/dib.ml
> +++ b/dib/dib.ml
> @@ -283,6 +283,7 @@ if [ -z \"$preserve_env\" ]; then
>    for envvar in `env | grep '^\\w' | cut -d= -f1`; do
>      case \"$envvar\" in
>        PATH | USER | USERNAME | HOSTNAME | TERM | LANG | HOME | SHELL | LOGNAME ) ;;
> +      BASH_FUNC_* ) unset -f $envvar ;;
>        *) unset $envvar ;;
>      esac
>    done
> 

LGTM, pushed.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20150812/b92dbc41/attachment.sig>