[Libguestfs] [PATCH v2 01/17] v2v: debug gc via at_exit hook
Roman Kagan
rkagan at virtuozzo.com
Fri Aug 28 13:45:19 UTC 2015
On Fri, Aug 28, 2015 at 02:15:34PM +0100, Richard W.M. Jones wrote:
> On Fri, Aug 28, 2015 at 03:44:07PM +0300, Roman Kagan wrote:
> > So what is your verdict regarding this patch? Do you want me to
> >
> > 1) drop it at all
> > 2) leave it as a part of this series
> > 3) submit it separately
> > 4) submit it separately together with similar changes to other tools for
> > uniformity
> >
> > Also (unless you want to drop the patch at all) I'm tempted to make one
> > step further and install an at_exit hook right in the command-line
> > parsing function, right where --debug-gc is handled, without passing it
> > on to the caller. Would it be OK to do so?
>
> If you can be bothered to do (4), then adding the at_exit hook in the
> command line parsing of all virt tools seems like the way to go here.
OK I'll go for it.
Thanks,
Roman.
More information about the Libguestfs
mailing list