[Libguestfs] [PATCH 2/2] builder: support Simple Streams v1.0 as index metadata

Richard W.M. Jones rjones at redhat.com
Wed Aug 12 16:28:55 UTC 2015


On Wed, Aug 12, 2015 at 03:12:22PM +0200, Pino Toscano wrote:
> +let object_find key yv =
> +  (match object_find_optional key yv with
> +  | None -> error (f_"missing value for the key '%s'") key
> +  | Some v -> v
> +  )

You don't need the extra parentheses around the match expr.

Could the yajl bindings be added in a separate patch?

Also be nice to have a little unit test for the yajl bindings.
I wasn't able to spot any bugs in the bindings.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list