[Libguestfs] [PATCH v2 03/17] v2v: factor out overlay creation

[Richard W.M. Jones]

On Tue, Aug 11, 2015 at 08:00:22PM +0300, Roman Kagan wrote:
> Iterating over source disks and creating temporary overlays for easy
> rollback fits nicely into a separate function.  In addition, determining
> their size doesn't need to wait until the guestfs is launched: the size
> can be obtained via disk_virtual_size() method.

This patch seems fine, but would prefer again that create_overlays was
moved after main (after amend_source in fact).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html