[Libguestfs] [PATCH 2/3] builder: Check HAVE_POSIX_FADVISE before using it

Pino Toscano ptoscano at redhat.com
Thu Feb 12 18:30:15 UTC 2015


On Thursday 12 February 2015 17:28:47 Margaret Lewicka wrote:
> ---
>  builder/pxzcat-c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/builder/pxzcat-c.c b/builder/pxzcat-c.c
> index 0bbd296..dec9cc2 100644
> --- a/builder/pxzcat-c.c
> +++ b/builder/pxzcat-c.c
> @@ -214,8 +214,10 @@ pxzcat (value filenamev, value outputfilev, unsigned nr_threads)
>      unix_error (err, (char *) "ftruncate", outputfilev);
>    }
>  
> +#if defined HAVE_POSIX_FADVISE
>    /* Tell the kernel we won't read the output file. */
>    ignore_value (posix_fadvise (fd, 0, 0, POSIX_FADV_RANDOM|POSIX_FADV_DONTNEED));
> +#endif
>  
>    /* Iterate over blocks. */
>    iter_blocks (idx, nr_threads, filenamev, fd, outputfilev, ofd);
> 

LGTM.

-- 
Pino Toscano




More information about the Libguestfs mailing list