[Libguestfs] Patchable build problems on OS X 10.10
Richard W.M. Jones
rjones at redhat.com
Mon Feb 9 13:04:02 UTC 2015
On Mon, Feb 09, 2015 at 10:29:20AM +0000, Margaret Lewicka wrote:
> On 9 February 2015 at 09:56, Pino Toscano <ptoscano at redhat.com> wrote:
> > On Friday 06 February 2015 10:03:37 Richard W.M. Jones wrote:
> [...]
> >> #if !(defined __APPLE__ && defined __MACH__)
> >> execlp ("fusermount", "fusermount", "-u", mountpoint, NULL);
> >> #else
> >> execlp ("/sbin/umount", "umount", mountpoint, NULL);
> >> #endif
> >
> > Or rather use fusermount only on Linux and umount (with no path)
> > elsewhere.
>
> I'm about to mail some patches, your reply arrived just in time. :)
> Is #ifdef __linux__ sufficient in this case, then? I don't want to
> make too general assumptions.
For this specific patch, yes.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
More information about the Libguestfs
mailing list