[Libguestfs] [PATCH v3 1/2] New API: btrfs_balance_status

[Chen, Hanxiao]

> -----Original Message-----
> From: Richard W.M. Jones [mailto:rjones at redhat.com]
> Sent: Wednesday, February 11, 2015 10:00 PM
> To: Chen, Hanxiao/陈 晗霄
> Cc: libguestfs at redhat.com
> Subject: Re: [Libguestfs] [PATCH v3 1/2] New API: btrfs_balance_status
> 
> On Wed, Feb 11, 2015 at 06:41:19PM +0800, Chen Hanxiao wrote:
> > +  if (nlines < 1)
> > +    return NULL;
> 
> This error handling is wrong.  It would cause the protocol between the
> appliance and library to become desynchronized.  You have to call one
> of the error functions -- eg. `reply_with_error' before returning
> NULL.
> 
> The rest of this patch looks fine, if this change was made.
> 

Will be fixed in next version.

Thanks,
- Chen