[Libguestfs] [PATCH] gnulib: Define argv[0] as program_name for error.c on Darwin

Richard W.M. Jones rjones at redhat.com
Fri Feb 13 11:52:46 UTC 2015


On Thu, Feb 12, 2015 at 07:09:41PM +0000, Margaret Lewicka wrote:
> On 12 February 2015 at 19:01, Pino Toscano <ptoscano at redhat.com> wrote:
> > On Thursday 12 February 2015 18:58:17 Margaret Lewicka wrote:
> [...]
> >> This was requested by Richard in <20150211220126.GV11603 at redhat.com>;
> >> the hack^Wsolution is his, I am merely providing the patch.
> >>
> >> (Would not send it myself because a) I believe libguestfs's
> >> executables should properly define the variable, rather than trying to
> >> circumvent the requirement, b) I don't have the knowledge to verify
> >> the solution past "it compiles and runs".)
> >
> > In any case, we cannot accept this patch, since it patches a file
> > coming from an external repository.  We just integrate gnulib in our
> > workflow, using the modules of it which are needed for us (either
> > to support quirks on different OSes, or to get some extra features).
> 
> Yes, I understand. Again, I sent this out only on Richard's request:
> "Please send a final patch to gnulib/lib/error.h and I'll forward it to
> the gnulib people for you (or you can send it yourself if you want)."

Yup this is fine, don't worry!

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html




More information about the Libguestfs mailing list