[Libguestfs] [PATCH v4 0/7] uuid: add btrfs uuid change support and set_uuid_random

Chen, Hanxiao chenhanxiao at cn.fujitsu.com
Wed Jul 1 08:53:41 UTC 2015



> -----Original Message-----
> From: libguestfs-bounces at redhat.com [mailto:libguestfs-bounces at redhat.com] On
> Behalf Of Pino Toscano
> Sent: Tuesday, June 30, 2015 10:09 PM
> To: libguestfs at redhat.com
> Subject: Re: [Libguestfs] [PATCH v4 0/7] uuid: add btrfs uuid change support and
> set_uuid_random
> 
> In data martedì 30 giugno 2015 19:23:07, Chen Hanxiao ha scritto:
> > - Btrfs-progs v4.1 introduced new feature of changing
> >   uuid of btrfs partition.
> >   This patch add support of this.
> >
> > - Introduce set_uuid_random
> >
> > - uuids.c did a lot of deplicated work for changing uuid
> >   of fs. Use existing functions.
> >
> > v4: introduce get_random_uuid
> >     improve testcases
> >     squash internal API patches
> > v3.1: fix typos
> > v3: set errno if feature is not available.
> >
> > Chen Hanxiao (7):
> >   uuid: add support to change uuid of btrfs partition
> >   uuid: use existing function of ext2
> >   uuid: use newly introduced xfs_set_uuid of xfs
> >   uuid: use newly introduced swap_set_uuid
> >   daemon: add get_random_uuid
> >   daemon: add functions for setting random uuid of fs
> >   New API: set_uuid_random
> >
> >  appliance/packagelist.in       |  1 +
> >  daemon/btrfs.c                 | 81 ++++++++++++++++++++++++++++++++++++++++++
> >  daemon/daemon.h                | 11 ++++++
> >  daemon/ext2.c                  | 15 ++++++++
> >  daemon/guestfsd.c              | 19 ++++++++++
> >  daemon/swap.c                  | 29 +++++++++++++++
> >  daemon/uuids.c                 | 71 +++++++++++++++++-------------------
> >  daemon/xfs.c                   | 14 ++++++++
> >  generator/actions.ml           | 16 +++++++++
> >  src/MAX_PROC_NR                |  2 +-
> >  tests/btrfs/test-btrfs-misc.pl | 36 +++++++++++++++++++
> >  11 files changed, 255 insertions(+), 40 deletions(-)
> 
> This patch series is getting better now.
> I pushed patches #2, #3 & #5, as they were okay. #4 is okay too,
> although it doesn't apply without #1.
> 
> Also, please squash patches #6 and #7 together, as those
> implementations are for set_uuid_random.

Fine, although #6 + #7 is a little big.

> 
> Thanks for the work,

Thanks for your comments and patience.

Regards,
- Chen





More information about the Libguestfs mailing list