[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] doc: add missing ms-dos fs section in set_label



On Monday 06 July 2015 17:13:51 Chen Hanxiao wrote:
> Signed-off-by: Chen Hanxiao <chenhanxiao cn fujitsu com>
> ---
>  generator/actions.ml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/generator/actions.ml b/generator/actions.ml
> index 92f80d2..35f30d5 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -9919,7 +9919,7 @@ Set the filesystem label on C<mountable> to C<label>.
>  Only some filesystem types support labels, and libguestfs supports
>  setting labels on only a subset of these.
>  
> -=over 4
> +=over 5

This is wrong, since the number is the indentation level, not the
number of items in the list. See also
http://perldoc.perl.org/perlpod.html

>  
>  =item ext2, ext3, ext4
>  
> @@ -9941,6 +9941,9 @@ not allowed.  Setting the label on a btrfs subvolume will set the
>  label on its parent filesystem.  The filesystem must not be mounted
>  when trying to set the label.
>  
> +=item fat
> +The label is limited to 11 bytes.
> +
>  =back
>  
>  To read the label on a filesystem, call C<guestfs_vfs_label>." };
> 

With the wrong hunk skipped, LGTM, pushed. 

Thanks,
-- 
Pino Toscano


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]