[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 6/6] customize: add basic subscription-manager operations



On Wed, Jul 08, 2015 at 04:42:18PM +0200, Pino Toscano wrote:
> +        error (f_"subscription-manager configuration required for this operation")

This error message should refer to the --sm-config option in some way,
so the error message is actionable.

---

Patches 1-5 are fine and can go upstream now.

I can't say that I'm overjoyed by the new config file format that we
need here.

Is it not possible to encode the configuration settings into --sm-*
parameters?

What about quoting - what happens if the password contains quotes or
newlines?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]