[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 6/6] customize: add basic subscription-manager operations



On Thursday 09 July 2015 13:39:33 Richard W.M. Jones wrote:
> On Wed, Jul 08, 2015 at 04:42:18PM +0200, Pino Toscano wrote:
> > +        error (f_"subscription-manager configuration required for this operation")
> 
> This error message should refer to the --sm-config option in some way,
> so the error message is actionable.
> 
> ---
> 
> Patches 1-5 are fine and can go upstream now.

I've not pushed them, as basically they move the ini reader from
virt-builder to mllib.

> I can't say that I'm overjoyed by the new config file format that we
> need here.

I basically made use of the ini configuration style as used elsewhere.
Anything in particular that concerns you?

> Is it not possible to encode the configuration settings into --sm-*
> parameters?

The idea is to have settings such as usernames, passwords, and maybe
also channel pools in a separate configuration, so they are not
shown in command line; this is similar to what is done in virt-customize
--password, and also --password-file in virt-v2v.

> What about quoting - what happens if the password contains quotes or
> newlines?

Right, fixed.

Thanks,
-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]