[Libguestfs] [PATCH 2/3] inspection: Add support for CoreOS

Richard W.M. Jones rjones at redhat.com
Tue Jun 2 14:10:01 UTC 2015


On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote:
> +  if (collect_coreos_inspection_info (g)) {
> +    guestfs_int_free_inspect_info (g);
> +    return NULL;
> +  }

Although this is stylistic, I think it's easier to understand if
you change the if condition to:

  if (collect_coreos_inspection_info (g) == -1) {
    ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html




More information about the Libguestfs mailing list