[Libguestfs] [PATCH v3.1 0/9] uuid: add btrfs uuid change support and set_uuid_random

Pino Toscano ptoscano at redhat.com
Fri Jun 26 13:11:27 UTC 2015


In data venerdì 26 giugno 2015 17:35:35, Chen Hanxiao ha scritto:
> - Btrfs-progs v4.1 introduced new feature of changing
>   uuid of btrfs partition.
>   This patch add support of this.
> 
> - Introduce set_uuid_random
> 
> - uuids.c did a lot of deplicated work for changing uuid
>   of fs. Use existing functions.
> 
> v3.1: fix typos
> v3: set errno if feature is not available.
> 
> Chen Hanxiao (9):
> [...]
>   uuid: use existing function of ext2
>   uuid: use newly introduced xfs_set_uuid of xfs
>   uuid: use newly introduced swap_set_uuid

These commits look good.

>   New API: btrfs_set_uuid_random
>   New API: set_e2uuid_random
>   New API: swap_set_uuid_random
>   New API: xfs_set_uuid_random
>   New API: set_uuid_random

New internal functions are not "new API" -- that is used for user-facing
APIs, such as set_uuid_random.

Could you also please squash them together, since they are not really
different changes from the set_uuid_random addition?

Commits 5,6,8 look good as well.

Thanks,
-- 
Pino Toscano




More information about the Libguestfs mailing list