[Libguestfs] [PATCH 0/7] Better testing of the guestfsd daemon.

[Pino Toscano]

In data martedì 23 giugno 2015 23:49:48, Richard W.M. Jones ha scritto:
> Currently we are unable to properly run guestfsd (the daemon) under
> valgrind.  Attempts to run valgrind inside the appliance have not been
> successful (see patch 1/7).
> 
> However we desperately need better valgrind coverage of the daemon,
> particularly because it is doing a lot of complex parsing of program
> output.  This has been a problem for a long time.

As also discussed on IRC, I will give a try in improving the current
--enable-valgrind-daemon, which works for me although it is a bit
cumbersome.

> A better way to attack this problem is to run the daemon as a regular
> host process and connect libguestfs directly to it.  Because of
> 'libguestfs live' functionality this is quite simple: we are able to
> connect the library to any Unix domain socket and talk directly to the
> daemon.
> 
> This patch series modified the daemon so it can be run as a standalone
> process listening on a Unix domain socket, adds new tests which run
> the daemon as a host process, and a simple framework to run the daemon
> under valgrind.

For the rest of the series, i.e. patches 2-7, I've left a couple of
notes. Otherwise, the idea is nice and most of the implementation
likewise.

Thanks,
-- 
Pino Toscano