[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/3] builder: enable batch mode when validating non-verbose (RHBZ#1180170)



On Mon, May 11, 2015 at 07:30:34PM +0200, Pino Toscano wrote:
> When running gpg to validate a signature, use also --batch in
> non-verbose mode to avoid the extra "Good signature" messages that are
> printed by gpg2 even in quiet mode.
> We are parsing the status output anyway to check the validation result,
> so this should be harmless (and the full gpg output is printed in
> verbose mode anyway).
> ---
>  builder/sigchecker.ml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builder/sigchecker.ml b/builder/sigchecker.ml
> index b54977f..29f271b 100644
> --- a/builder/sigchecker.ml
> +++ b/builder/sigchecker.ml
> @@ -159,7 +159,7 @@ and do_verify t args =
>    let cmd =
>      sprintf "%s --homedir %s --verify%s --status-file %s %s"
>          t.gpg t.gpghome
> -        (if t.verbose then "" else " -q --logger-file /dev/null")
> +        (if t.verbose then "" else " --batch -q --logger-file /dev/null")
>          (quote status_file) args in
>    if t.verbose then printf "%s\n%!" cmd;
>    let r = Sys.command cmd in
> -- 
> 2.1.0

ACK series.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]