[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] mllib: Require OUnit2 for tests.



On Monday 11 May 2015 20:45:28 Richard W.M. Jones wrote:
> On Mon, May 11, 2015 at 07:22:58PM +0200, Pino Toscano wrote:
> > On Monday 11 May 2015 11:11:50 Richard W.M. Jones wrote:
> > > OUnit2 has an OUnit (v1) compatibility module.  Unfortunately it
> > > is rather gravely broken:
> > > https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730
> > > 
> > > Since there is no new release fixing this, it's easier to switch to
> > > using OUnit2 for unit tests.
> > 
> > A pity, for the bug and the fact that there's no oUnit v2 for
> > Fedora 21...
> > It is not a problem for me anyway, just ...
> > 
> > > ---
> > >  .gitignore                  |  2 +-
> > >  README                      |  2 +-
> > >  mllib/JSON_tests.ml         | 56 ++++++++++++++++++++-------------------------
> > >  mllib/Makefile.am           |  2 ++
> > >  mllib/common_utils_tests.ml | 50 +++++++++++++++++-----------------------
> > >  5 files changed, 50 insertions(+), 62 deletions(-)
> > 
> > ... please adjust configure.ac to look for oUnit2 instead of oUnit.
> 
> This should do it:
> 
> https://github.com/libguestfs/libguestfs/commit/46bc79109bb51cfb656863da3635f1c8da5f6412

It does, although the tests build fails in mllib because of a spurious
check_SCRIPTS variable; fix coming.

Also, I've simplified the above commit, making use of the existing
m4 OCaml macros.

-- 
Pino Toscano


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]