[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] mllib: remove spurious check_SCRIPTS from Makefile.am



On Tue, May 12, 2015 at 03:20:56PM +0200, Pino Toscano wrote:
> Not actually useful, as TESTS defines the tests, and it breaks when
> oUnit is not available (as it tries to build an oUnit-based unit test).
> ---
>  mllib/Makefile.am | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mllib/Makefile.am b/mllib/Makefile.am
> index 0b43684..e363f27 100644
> --- a/mllib/Makefile.am
> +++ b/mllib/Makefile.am
> @@ -132,9 +132,6 @@ libdir.ml: Makefile
>  
>  # Tests.
>  
> -check_SCRIPTS = \
> -	common_utils_tests
> -
>  if HAVE_OCAMLOPT
>  common_utils_tests.cmx: OCAMLPACKAGES += $(OCAMLPACKAGES_TESTS)
>  common_utils_tests: config.cmx common_gettext.cmx common_utils.cmx common_utils_tests.cmx
> -- 

I don't think this is spurious (although it doesn't do very much).
Automake wants us to list all built scripts in a check_SCRIPTS rule,
of which this is one.  See section 9.1 Executable Scripts in the
automake info file.

It probably does need to be changed to:

check_SCRIPTS =
if HAVE_OCAML_PKG_OUNIT
check_SCRIPTS += common_utils_tests
endif

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]