[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v4 0/2] inspector: recognize ppc64 and ppc64le archs (RHBZ#1211996)



On Tuesday 19 May 2015 20:23:36 Maros Zatko wrote:
> Patch extracts MSB/LSB info from /bin/file output and passes it as separate
> parameret from elf_arch. Then it is sent to impl_file_architecture and checked/
> 
> Modified magic_for_file to handle regex changes.
> 
> Now with tests for file_architecture.
> 
> Fixes: RHBZ#1211996
> 
> Maros Zatko (2):
>   inspector: recognize ppc64 and ppc64le archs (RHBZ#1211996)
>   tests: ppc64 and ppc64le for file_architecture

Except one small note in patch 1, it seems generally good.

One thing though, could you please merge the tests into the main
commit, so it's more clear they go together?

Thanks for the work,
-- 
Pino Toscano


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]