[Libguestfs] [PATCH 2/2] actions: refactor available & feature_available

[Pino Toscano]

On Friday 06 November 2015 21:40:53 Richard W.M. Jones wrote:
> On Thu, Nov 05, 2015 at 04:56:43PM +0100, Pino Toscano wrote:
> > Refactor the internal_feature_available to return the result for just
> > one group, so it is easier to know on the library side what was the
> > actual error, and which group refers to; drop internal_available, as no
> > more needed after this.
> > 
> > On the library side, implement in available and feature_available the
> > real logic to iterate through the requested group, and error out or
> > return whether the groups are available. This also introduces caching
> > for the features, so each needs to be queried just once in each
> > appliance run.
> > 
> > The result of this is that there should be much less communication with
> > the daemon to know about available features; the downside is that
> > queries for more than one group at once, not already cached, will be
> > cause more queries to the daemon.
> 
> This commit causes the following valgrind failures.  Curiously they
> only occur in virt-v2v:

I can reproduce it also on other tools, and I found the issue of that.
Patch(es) will come in a minute.

Thanks for pointing it out,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20151109/4630b960/attachment.sig>