[Libguestfs] [PATCH] v2v: Make the interface between cmdline.ml and v2v.ml

Richard W.M. Jones rjones at redhat.com
Wed Nov 11 14:52:43 UTC 2015


On Wed, Nov 11, 2015 at 02:28:16PM +0100, Pino Toscano wrote:
> Sounds nice as approach -- why not adding also input and output to the
> struct?

I did that initially, but I found that confusing.  The problem is that
input & output are mutable objects (so they are passed to virtually
every function and they are updated as v2v.ml progresses), whereas all
of the other cmdline.* fields are immutable cmdline parameter values.

I don't think any other tool apart from virt-v2v would have this
problem/inconsistency though.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list