[Libguestfs] [PATCH 5/5] build: Enable some more warnings.

[Pino Toscano]

On Wednesday 18 November 2015 10:41:33 Richard W.M. Jones wrote:
> On Wed, Nov 18, 2015 at 11:19:02AM +0100, Pino Toscano wrote:
> > On Monday 09 November 2015 23:02:15 Richard W.M. Jones wrote:
> > > After fixing some warnings (see prior commits), we can now enable
> > > them in configure.ac.
> > > ---
> > > [...]
> > > -nw="$nw -Winline"                    # daemon.h's asprintf_nowarn
> > 
> > Disabling -Winline causes the Python binding code to fail with build
> > with GCC < 4.9, because of the static inline functions in
> > python/guestfs-py.h. See for example on CentOS 7.1 and openSUSE 13.1:
> > https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-CentOS-7-slave01/108/console
> > https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-opensuse-13.2-slave01/108/console
> > 
> > Would it be acceptable to de-inline them into normal functions?
> 
> The -Winline warning looks completely useless.  Who cares if a
> function can't be inlined?  So enabling it was probably a mistake.
> Can we disable it (the warning) again?

OK for me.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20151118/86c16edc/attachment.sig>