[Libguestfs] installation error

Richard W.M. Jones rjones at redhat.com
Tue Nov 24 11:47:29 UTC 2015


On Sun, Nov 22, 2015 at 08:48:32PM +0200, Keresztes Péter-Zoltán wrote:
> Never mind I was missing libreadline-dev
> I gues this check would be good to be added with an error to the configure script since it creates error in compilation

readline is supposed to be optional - the bug is in libguestfs
which shouldn't fail if readline is not installed.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
-------------- next part --------------
>From e49680bdd6dfd4a2adf14b5919d466be553280c6 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones at redhat.com>
Date: Tue, 24 Nov 2015 11:14:37 +0000
Subject: [PATCH] fish: ps_restore is only used when HAVE_LIBREADLINE is
 defined.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thanks: Keresztes Péter-Zoltán
---
 fish/fish.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fish/fish.c b/fish/fish.c
index 6e5213c..0328f2a 100644
--- a/fish/fish.c
+++ b/fish/fish.c
@@ -645,8 +645,8 @@ shell_script (void)
 static char *ps1 = NULL;        /* GUESTFISH_PS1 */
 static char *ps_output = NULL;  /* GUESTFISH_OUTPUT */
 static char *ps_init = NULL;    /* GUESTFISH_INIT */
-#endif /* HAVE_LIBREADLINE */
 static char *ps_restore = NULL; /* GUESTFISH_RESTORE */
+#endif /* HAVE_LIBREADLINE */
 static char *line_read = NULL;
 
 static char *
-- 
2.5.0



More information about the Libguestfs mailing list