[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH supermin] build: use a custom test driver



On Fri, Nov 06, 2015 at 02:12:50PM +0100, Pino Toscano wrote:
> On Friday 06 November 2015 13:00:03 Richard W.M. Jones wrote:
> > On Fri, Nov 06, 2015 at 01:24:07PM +0100, Pino Toscano wrote:
> > > Use a custom test driver for running the tests: based on the test-driver
> > > provided by automake, it adds the running time of the test in each .trs
> > > file.
> > > ---
> > >  configure.ac        |   1 +
> > >  guestfs-test-driver | 151 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 
> > supermin-test-driver ..?
> 
> Can do.
> 
> > I applied this to the supermin tree to try and see how it worked,
> > but I can't see what it's supposed to do.  I still see the usual
> > `PASS:' lines in the output.
> 
> Yes, that's expected. The difference is just in what gets in the
> resulting .trs files, which now have a line like:
> :guestfs-time: 1
> which indicates how much time each test took; this way, we can parse it
> and improve the resulting XML for junit (produced by
> tests/automake2junit.ml in CI).
> 
> The plan is to apply the same also to libguestfs when switching to
> parallel-tests, so we can get proper test results for CI even without
> $RUN_OUTPUT_FILE.
> 
> > I don't know whether or not you use emacs, but:
> > 
> > > +# Local Variables:
> > > +# mode: shell-script
> > > +# sh-indentation: 2
> > > +# eval: (add-hook 'write-file-hooks 'time-stamp)
> > > +# time-stamp-start: "scriptversion="
> > > +# time-stamp-format: "%:y-%02m-%02d.%02H"
> > > +# time-stamp-time-zone: "UTC"
> > > +# time-stamp-end: "; # UTC"
> > > +# End:
> > 
> > are super annoying.  It even popped up when I opened the reply to this
> > email message.
> 
> This is part of the test-driver file in upstream automake (which gets
> copied in the build tree).  Should I remove them from the local copy?

If it's not too much trouble, then yes please remove that (it even
just got me again now when replying).

ACK with those changes.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]