[Libguestfs] [PATCH 5/5] build: Enable some more warnings.

[Pino Toscano]

On Monday 09 November 2015 23:02:15 Richard W.M. Jones wrote:
> After fixing some warnings (see prior commits), we can now enable
> them in configure.ac.
> ---
> [...]
> -nw="$nw -Winline"                    # daemon.h's asprintf_nowarn

Disabling -Winline causes the Python binding code to fail with build
with GCC < 4.9, because of the static inline functions in
python/guestfs-py.h. See for example on CentOS 7.1 and openSUSE 13.1:
https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-CentOS-7-slave01/108/console
https://ci.centos.org/view/libguestfs/job/libguestfs/label=libguestfs-ci-opensuse-13.2-slave01/108/console

Would it be acceptable to de-inline them into normal functions?

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20151118/a3a9db34/attachment.sig>