[Libguestfs] [PATCH 0/4] v2v: simplify driver copying from virtio-win iso
Richard W.M. Jones
rjones at redhat.com
Thu Oct 1 15:09:26 UTC 2015
On Thu, Oct 01, 2015 at 06:04:03PM +0300, Roman Kagan wrote:
> On Mon, Aug 10, 2015 at 06:55:28PM +0300, Roman Kagan wrote:
> > Libguestfs supports passing an ISO image as a source of virtio windows
> > drivers to v2v.
> >
> > That support, however, looks too heavy-weight: in order to access those
> > drivers, a separate guestfs handle is created (and thus a new emulator
> > process is started), which runs until v2v completes.
> >
> > This series attempts to make it simpler and lighter-weight, by making
> > the relevant code more local, and by hot-adding the image into the main
> > guestfs handle.
> >
> > Roman Kagan (4):
> > v2v: drop useless forced gc
> > v2v: consolidate virtio-win file copying
> > v2v: copy virtio drivers without guestfs handle leak
> > v2v: reuse main guestfs for virtio win drivers iso
> >
> > v2v/convert_windows.ml | 184 ++++++++++++++++++++--------------------
> > v2v/utils.ml | 224 ++++++++++++++++---------------------------------
> > v2v/v2v.ml | 8 --
> > 3 files changed, 163 insertions(+), 253 deletions(-)
>
> I just realized that, although (at least two of) these patches got
> "likely ACK", they are not in the libguestfs tree.
>
> The patches still apply to master as of today.
>
> Is there anything I can do to get them merged?
What happened was I wanted to look at why the inner handle never got
GC'd. And I did have a look at that, couldn't work out for the life
of me why, and gave up.
I'm going to look at the two patches again, so give me a bit.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
More information about the Libguestfs
mailing list