[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/6] tests: use fake rhsrvany.exe

On Mon, Oct 05, 2015 at 03:40:01PM +0300, Roman Kagan wrote:
> -guestsdir="$(cd ../tests/guests && pwd)"
> -f="$guestsdir/windows.img"
> +abs_top_builddir="$(cd ..; pwd)"

You don't need to define abs_top_builddir, as it should already be
defined.  However it won't be exported to the test scripts unless you
change v2v/Makefile.am: TESTS_ENVIRONMENT to include it, something
like this:

-TESTS_ENVIRONMENT = $(top_builddir)/run --test
+TESTS_ENVIRONMENT = abs_top_builddir="$(abs_top_builddir)" $(top_builddir)/run --test

> diff --git a/tests/fake-virt-tools/rhsrvany.exe b/tests/fake-virt-tools/rhsrvany.exe
> new file mode 100644
> index 0000000..b474349
> --- /dev/null
> +++ b/tests/fake-virt-tools/rhsrvany.exe
> @@ -0,0 +1 @@
> +This is a fake rhsrvany.exe, used for testing only
> diff --git a/tests/regressions/rhbz1232192.sh b/tests/regressions/rhbz1232192.sh

This doesn't appear in EXTRA_DIST, so it won't be copied to the tarball.

TBH I'd prefer if the fake-virt-tools directory was a subdir of v2v/
so you can just add fake-virt-tools/rhsrvany.exe to EXTRA_DIST that is
already defined in v2v/Makefile.am.

ACK the patch with these changes.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]