[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/6] v2v:test:win: actually check the eventual layout



On Mon, Oct 05, 2015 at 03:40:03PM +0300, Roman Kagan wrote:
> v2v/test-v2v-windows-conversion.sh used to query if the expected
> directories and filed were present in the VM upon conversion; however it
> would ignore the results of that query.
> 
> That lead to the test passing even though the checks failed.

Good point.  Fix is kinda ugly though.  How about:

output=$(
  guestfish --ro -a $d/windows-sda -i <<EOF
  is-dir "/Program Files/Red Hat/Firstboot"
  ...
)
if [ "$output" != "true
true
true
true" ]; then
  echo "$0: firstboot files were not copied into the guest"
  echo "$0: test output was:"
  echo "$output"
  exit 1
fi

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]