[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/5] mllib: Don't alias G = Guestfs in Common_utils module.



On Tuesday 06 October 2015 13:30:46 Richard W.M. Jones wrote:
> ---
>  mllib/common_utils.ml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml
> index f8fa8fd..f9c45cc 100644
> --- a/mllib/common_utils.ml
> +++ b/mllib/common_utils.ml
> @@ -20,8 +20,6 @@ open Printf
>  
>  open Common_gettext.Gettext
>  
> -module G = Guestfs
> -

Hm weren't we using that alias in our .ml files, usually?
Not a big deal, I just remember changes in the opposite way of this
patch, so just wondering what would be the preferred way (especially
that there is a .mli for this, so the alias won't pollute users of the
module).

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]