[Libguestfs] [PATCH v2 4/5] v2v:tests: use fake virtio-win drivers

Richard W.M. Jones rjones at redhat.com
Thu Oct 8 14:53:24 UTC 2015


I'm just testing patches 1-3, and if they pass I will push them.

On Thu, Oct 08, 2015 at 04:50:35PM +0300, Roman Kagan wrote:
> +fake_virtio_win_dir = fake-virtio-win
> +FAKE_VIRTIO_WIN = $(wildcard $(fake_virtio_win_dir)/*/*/*/*)

Why the fake_virtio_win_dir variable?  Unfortunately automake treats
variables that have '*dir' in the name specially, but in this case I
don't think you intended that.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list