[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 4/4] v2v: reuse main guestfs for virtio win drivers iso

On Tue, Oct 13, 2015 at 03:50:54PM +0300, Roman Kagan wrote:
> If we're given an ISO image as the source of virtio windows drivers, and
> the backend supports hot-adding drives, reuse the same guestfs handle
> that is open for accessing the guest being inspected, rather than
> creating a new one (which would run another virtual machine instance and
> is fairly resource-intensive).

I really don't like this specific patch.  Hotplugging is not very
reliable in my experience.  The patch tries to work out if hotplugging
is going to work by calling guestfs_add_drive and taking an alternate
path, but I'm not so convinced that would work on other architectures
(eg. hotplugging on aarch64 is in various states between not working
at all and flaky).

Are you observing any benefit with this patch?  v2v conversion takes a
long time - I can't believe the extra overhead of creating a handle
could make much difference.

I'll look at the other patches soon.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]