[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 1/4] v2v: consolidate virtio-win file copying

On Tue, Oct 13, 2015 at 03:50:51PM +0300, Roman Kagan wrote:
> -    match drivers with
> -    | [] ->
> -       warning (f_"there are no virtio drivers available for this version of Windows (%d.%d %s %s).  virt-v2v looks for drivers in %s\n\nThe guest will be configured to use slower emulated devices.")
> -               inspect.i_major_version inspect.i_minor_version
> -               inspect.i_arch inspect.i_product_variant
> -               virtio_win;
> -       ( IDE, RTL8139, Cirrus )

I believe this warning gets lost in this patch.

To get it back, let's make 'copy_virtio_drivers' returns a true/false
indication ('true' meaning that at least some drivers were copied),
and the caller code in 'install_virtio_drivers' should check this, and
either do the code above, or continue with the code below.

> +    copy_virtio_drivers driverdir;
> +
> +    (* Can we install the block driver? *)
> +    let block : guestcaps_block_type =
> +      let source = driverdir // "viostor.sys" in
> +      if (g#exists source) then (

Don't need parentheses around if-conditions.

The rest of the patch looks good with these two changes.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]