[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] New API: resize2fs_P



On Tue, Oct 13, 2015 at 11:14:29PM +0100, Richard W.M. Jones wrote:
> > +    if ((p = strstr (lines[i], pattern))) {
> > +      if (sscanf (p + strlen(pattern), "%" SCNu64, &ret) != 1)

Actually this fails to compile:

ext2.c: In function 'do_resize2fs_P':
ext2.c:308:40: error: format '%lu' expects argument of type 'long unsigned int *', but argument 3 has type 'int64_t * {aka long int *}' [-Werror=format=]
       if (sscanf (p + strlen(pattern), "%" SCNu64, &ret) != 1)

It'd be good to have a test as well, ie. a tests = ... section
in generator/actions.ml.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]